Skip to content

DOC: Typo(s?) in pandas.DataFrame.isin #43820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2021
Merged

DOC: Typo(s?) in pandas.DataFrame.isin #43820

merged 1 commit into from
Oct 3, 2021

Conversation

Varun270
Copy link
Contributor

@jreback jreback added this to the 1.4 milestone Sep 30, 2021
@jreback jreback changed the title fixed Issued No.#43755 DOC: Typo(s?) in pandas.DataFrame.isin Sep 30, 2021
jreback
jreback reviewed Sep 30, 2021
View reviewed changes
pandas/core/frame.py Outdated
... index=['spider', 'falcon'])
>>> df.isin(other)
num_legs num_wings
falcon True True
falcon False True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick can you line these up (as would happen in the terminal)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to adjust True and False in line 10572?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think jeff means deleting one whitespace between falcon and false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood , I am force pushing the suggested changes

@Varun270
Copy link
Contributor Author

Varun270 commented Oct 3, 2021

@jreback I did the changes you suggested, you can review them.

phofl
phofl approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jreback jreback merged commit 4463fb1 into pandas-dev:master Oct 3, 2021
@jreback
Copy link
Contributor

jreback commented Oct 3, 2021

thanks @Varun270

gasparitiago pushed a commit to gasparitiago/pandas that referenced this pull request Oct 9, 2021
@Varun270 @gasparitiago
fixed Issued No.pandas-dev#43755 (pandas-dev#43820)
8b37530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

DOC: Typo(s?) in pandas.DataFrame.isin
4 participants
@Varun270 @jreback @phofl @debnathshoham